Skip to content

OCPNODE-3895,OCPNODE-3894,OCPNODE-3779: Enable DRA(DynamicResourceAllocation) featuregate by default #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Dec 4, 2025
Merged

OCPNODE-3895,OCPNODE-3894,OCPNODE-3779: Enable DRA(DynamicResourceAllocation) featuregate by default #2498

openshift-merge-bot merged 2 commits into from
Dec 4, 2025

Conversation

@sairameshv
Copy link
Member

@sairameshv sairameshv commented Sep 23, 2025

DRA has been graduated to GA in upstream 1.34[1] and is required to be enabled for OCP-4.21 rebase to unblock the DRA based e2e test failures[2]

[1] - https://kubernetes.io/blog/2025/09/01/kubernetes-v1-34-dra-updates/
[2] - https://issues.redhat.com/browse/OCPBUGS-61381

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2025

@sairameshv: This pull request references Jira Issue OCPBUGS-61381, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

DRA has been graduated to GA in upstream 1.34[1] and is required to be enabled for OCP-4.21 rebase to unblock the DRA based e2e test failures[2]

[1] - https://kubernetes.io/blog/2025/09/01/kubernetes-v1-34-dra-updates/
[2] - https://issues.redhat.com/browse/OCPBUGS-61381

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

Hello @sairameshv! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot requested a review from lyman9966 September 23, 2025 16:37
@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 23, 2025
@sairameshv
Copy link
Member Author

sairameshv commented Sep 23, 2025

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2025

@sairameshv: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test build

/test e2e-aws-ovn

/test e2e-aws-ovn-hypershift

/test e2e-aws-ovn-hypershift-conformance

/test e2e-aws-ovn-techpreview

/test e2e-aws-serial-1of2

/test e2e-aws-serial-2of2

/test e2e-aws-serial-techpreview-1of2

/test e2e-aws-serial-techpreview-2of2

/test e2e-azure

/test e2e-gcp

/test e2e-upgrade

/test e2e-upgrade-out-of-change

/test images

/test integration

/test lint

/test minor-e2e-upgrade-minor

/test minor-images

/test okd-scos-images

/test unit

/test verify

/test verify-client-go

/test verify-crd-schema

/test verify-crdify

/test verify-deps

/test verify-feature-promotion

The following commands are available to trigger optional jobs:

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-api-master-build

pull-ci-openshift-api-master-images

pull-ci-openshift-api-master-integration

pull-ci-openshift-api-master-lint

pull-ci-openshift-api-master-minor-e2e-upgrade-minor

pull-ci-openshift-api-master-minor-images

pull-ci-openshift-api-master-okd-scos-e2e-aws-ovn

pull-ci-openshift-api-master-okd-scos-images

pull-ci-openshift-api-master-unit

pull-ci-openshift-api-master-verify

pull-ci-openshift-api-master-verify-client-go

pull-ci-openshift-api-master-verify-crd-schema

pull-ci-openshift-api-master-verify-crdify

pull-ci-openshift-api-master-verify-deps

pull-ci-openshift-api-master-verify-feature-promotion

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

haircommander
haircommander reviewed Sep 23, 2025
View reviewed changes
@sairameshv
Copy link
Member Author

sairameshv commented Sep 23, 2025

/test e2e-gcp

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 24, 2025
@sairameshv sairameshv marked this pull request as ready for review September 24, 2025 11:13
@sairameshv sairameshv changed the title WIP: OCPBUGS-61381: Enable DRA(DynamicResourceAllocation) featuregate by default OCPBUGS-61381: Enable DRA(DynamicResourceAllocation) featuregate by default Sep 24, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2025
JoelSpeed
JoelSpeed reviewed Sep 24, 2025
View reviewed changes
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2025
@sairameshv
Copy link
Member Author

sairameshv commented Oct 1, 2025

Just FYI,
I see the e2e tests related to DRA are present with two different tags:

  1. DynamicResourceAllocation : These tests are by default disabled in our o/k repository. These are not even running on the TPNU clusters. Raised a PR to enable these jobs to get signal
  2. DRA : These are the new set of tests that are failing on non TPNU/default cluster type jobs but passing on the TPNU jobs(ref) as the upstream DRA is graduated to GA and the downstream "DynamicResourceAllocation" feature gate is enabled only for TPNU and not the default cluster types

Following is the output of DRA jobs passing for reference from the output log of the techpreview job

started: 0/33/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports init containers [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (15.2s) 2025-09-30T07:15:24 "[sig-node] [DRA] control plane [ConformanceCandidate] supports init containers [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/156/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports simple pod referencing external resource claim [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/177/652 "[sig-node] [DRA] control plane supports count/resourceclaims.resource.k8s.io ResourceQuota [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (12.9s) 2025-09-30T07:16:28 "[sig-node] [DRA] control plane [ConformanceCandidate] supports simple pod referencing external resource claim [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (10.1s) 2025-09-30T07:16:36 "[sig-node] [DRA] control plane supports count/resourceclaims.resource.k8s.io ResourceQuota [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/235/652 "[sig-node] [DRA] ResourceSlice Controller creates slices [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/236/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports claim and class parameters [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (14s) 2025-09-30T07:17:16 "[sig-node] [DRA] control plane [ConformanceCandidate] supports claim and class parameters [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/294/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports inline claim referenced by multiple containers [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (15.7s) 2025-09-30T07:18:03 "[sig-node] [DRA] control plane [ConformanceCandidate] supports inline claim referenced by multiple containers [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (1m14s) 2025-09-30T07:18:16 "[sig-node] [DRA] ResourceSlice Controller creates slices [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/388/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports sharing a claim concurrently [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/394/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports external claim referenced by multiple containers of multiple pods [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (13.9s) 2025-09-30T07:18:55 "[sig-node] [DRA] control plane [ConformanceCandidate] supports sharing a claim concurrently [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (12.6s) 2025-09-30T07:18:58 "[sig-node] [DRA] control plane [ConformanceCandidate] supports external claim referenced by multiple containers of multiple pods [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/420/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports simple pod referencing inline resource claim [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/435/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports reusing resources [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (13s) 2025-09-30T07:19:14 "[sig-node] [DRA] control plane [ConformanceCandidate] supports simple pod referencing inline resource claim [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/470/652 "[sig-node] [DRA] control plane validate ResourceClaimTemplate and ResourceClaim for admin access [FeatureGate:DRAAdminAccess] [Beta] [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (18.2s) 2025-09-30T07:19:26 "[sig-node] [DRA] control plane [ConformanceCandidate] supports reusing resources [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (6.4s) 2025-09-30T07:19:32 "[sig-node] [DRA] control plane validate ResourceClaimTemplate and ResourceClaim for admin access [FeatureGate:DRAAdminAccess] [Beta] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/498/652 "[sig-node] [DRA] control plane truncates the name of a generated resource claim [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (11.1s) 2025-09-30T07:19:49 "[sig-node] [DRA] control plane truncates the name of a generated resource claim [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/525/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports external claim referenced by multiple pods [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (13.6s) 2025-09-30T07:20:15 "[sig-node] [DRA] control plane [ConformanceCandidate] supports external claim referenced by multiple pods [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/639/652 "[sig-node] [DRA] control plane must apply per-node permission checks [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (9.4s) 2025-09-30T07:21:46 "[sig-node] [DRA] control plane must apply per-node permission checks [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"

I'm also monitoring the o/k PR's techpreview jobs to get the results of the DynamicResourceAllocation tagged e2e tests here

cc: @JoelSpeed @everettraven @tkashem

@everettraven
Copy link
Contributor

everettraven commented Oct 1, 2025 •
edited
Loading

Regarding the multiple different naming conventions, can we use anything similar to the logic outlined in https://github.com/openshift-eng/openshift-tests-extension/blob/d81c090588352f8cd80934dc61e10b443feca7d7/cmd/example-tests/main.go#L89-L120 to do some labelling/renaming so that all the tests follow enablement/disablement based on the state of the feature gate? Our test tooling should already know how to filter tests based on enabled/disabled feature gates as long as the test spec names are correctly annotated with the feature gate.

Having the correct annotations injected would also make it so that the tests report into Sippy in a way that verify-feature-promotion can detect

@benluddy
Copy link
Contributor

benluddy commented Oct 1, 2025

/hold

Please don't merge this until we merge @tkashem's cluster-kube-apiserver-operator PRs. We could end up in another situation where OpenShift serves default-disabled APIs in a GA build.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
@sairameshv
make update, update-codegen-crds
6127c8d 
Signed-off-by: Sai Ramesh Vanka <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@haircommander
Copy link
Member

haircommander commented Dec 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2025

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@sairameshv
Copy link
Member Author

sairameshv commented Dec 2, 2025

/verified later by @asahay19

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2025

@sairameshv: Only users can be targets for the /verified later command.

In response to this:

/verified later by @asahay19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sairameshv
Copy link
Member Author

sairameshv commented Dec 2, 2025

/verified later @asahay19

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Dec 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2025

@sairameshv: This PR has been marked to be verified later by @asahay19.

In response to this:

/verified later @asahay19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sairameshv
Copy link
Member Author

sairameshv commented Dec 2, 2025

/retest-required

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 02f6733 and 2 for PR HEAD 6127c8d in total

@everettraven
Copy link
Contributor

everettraven commented Dec 2, 2025

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, haircommander, ingvagabund, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@everettraven
Copy link
Contributor

everettraven commented Dec 2, 2025

/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crd-schema, ci/prow/verify-crdify

In response to this:

/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csrwng
Copy link
Contributor

csrwng commented Dec 2, 2025

/retest-required

3 similar comments
@sairameshv
Copy link
Member Author

sairameshv commented Dec 3, 2025

/retest-required

@sairameshv
Copy link
Member Author

sairameshv commented Dec 3, 2025

/retest-required

@tkashem
Copy link
Contributor

tkashem commented Dec 3, 2025

/retest-required

@sairameshv
Copy link
Member Author

sairameshv commented Dec 3, 2025 •
edited
Loading

Both the failures of ci/prow/e2e-upgrade[1] and ci/prow/e2e-aws-serial-techpreview-2of2[2] seem to be related to node drain failure due to the pdb set for catalogd-controller-manager pod

[1] - https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2498/pull-ci-openshift-api-master-e2e-upgrade/1996118601991458816
[2] - https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2498/pull-ci-openshift-api-master-e2e-aws-serial-techpreview-2of2/1996118601953710080

Openshift CI search ref: here

@sairameshv
Copy link
Member Author

sairameshv commented Dec 3, 2025

This PR[1] disables the pdb for catalogd-controller-manager and would hopefully resolve the failures

[1] - openshift/operator-framework-operator-controller#574

@haircommander
Copy link
Member

haircommander commented Dec 3, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025 •
edited
Loading

@sairameshv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 134c9e0 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nee1esh
Copy link

nee1esh commented Dec 3, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit a199b18 into openshift:master Dec 4, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benluddy benluddy benluddy left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@everettraven everettraven everettraven approved these changes

@lyman9966 lyman9966 Awaiting requested review from lyman9966

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

+3 more reviewers

@tkashem tkashem tkashem left review comments

@ingvagabund ingvagabund ingvagabund left review comments

@haircommander haircommander haircommander left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tkashem tkashem

@ingvagabund ingvagabund

@haircommander haircommander

@everettraven everettraven

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.